linux-kernel - Re: [PATCH] cpufreq: intel_pstate: Add Knights Mill CPUID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1991911.AIWBrncZ9n@vostro.rjw.lan>
Date:   Wed, 12 Oct 2016 21:39:24 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Piotr Luc <piotr.luc@...el.com>
Cc:     Viresh Kumar <viresh.kumar@...aro.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Len Brown <lenb@...nel.org>
Subject: Re: [PATCH] cpufreq: intel_pstate: Add Knights Mill CPUID

On Wednesday, October 12, 2016 08:25:50 PM Piotr Luc wrote:
> Add Knights Mill (KNM) to the list of CPUIDs supported by intel_pstate.
> 
> Signed-off-by: Piotr Luc <piotr.luc@...el.com>
> Reviewed-by: Dave Hansen <dave.hansen@...el.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Cc: Len Brown <lenb@...nel.org>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: linux-pm@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
> Depends-on: x86/cpu/intel: Add Knights Mill to Intel family
> https://lkml.kernel.org/r/20161012180520.30976-1-piotr.luc () intel ! com

First, putting broken URLs into patch tags doesn't really help.

Second, please send all of these patches as a series where the first
patch makes the change the rest depends on.  That would make them easier to
handle.

> 
>  drivers/cpufreq/intel_pstate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index be9eade..4240aff 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1367,6 +1367,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids[] = {
>  	ICPU(INTEL_FAM6_SKYLAKE_DESKTOP,	core_params),
>  	ICPU(INTEL_FAM6_BROADWELL_XEON_D,	core_params),
>  	ICPU(INTEL_FAM6_XEON_PHI_KNL,		knl_params),
> +	ICPU(INTEL_FAM6_XEON_PHI_KNM,		knl_params),
>  	ICPU(INTEL_FAM6_ATOM_GOLDMONT,		bxt_params),
>  	{}
>  };
> 

Thanks,
Rafael