[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20161013143922.GA17656@rapoport-lnx>
Date: Thu, 13 Oct 2016 17:39:22 +0300
From: Mike Rapoport <mike.rapoport@...il.com>
To: Edward Lipinsky <ellipinsky@...il.com>
Cc: Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
linux-fbdev@...r.kernel.org, sudip@...torindia.org,
teddy.wang@...iconmotion.com, linux-kernel@...r.kernel.org,
sudipm.mukherjee@...il.com
Subject: Re: [PATCH] staging: sm750fb: Fix printk() style warning
On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote:
>
> Thanks, that makes sense. I tried deleting the if statement and printk()
> from ddk750_help.c, and adding the following in lynxfb_pci_probe() after
> calling hw_sm750_map() and checking for errors:
>
> if (sm750_dev->revid == 0xfe)
> dev_info(&pdev->dev, "found sm750le\n");
>
> The driver compiles, loads and unloads ok with this code.
>
> Does this look correct?
Yep, seems just right.
> Regards,
> Ed L.
Powered by blists - more mailing lists