linux-kernel - Re: [PATCH] staging: sm750fb: Fix printk() style warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161014051825.GA22102@gmail.com>
Date:   Thu, 13 Oct 2016 22:18:25 -0700
From:   Edward Lipinsky <ellipinsky@...il.com>
To:     Mike Rapoport <mike.rapoport@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
        linux-fbdev@...r.kernel.org, sudip@...torindia.org,
        teddy.wang@...iconmotion.com, linux-kernel@...r.kernel.org,
        sudipm.mukherjee@...il.com
Subject: Re: [PATCH] staging: sm750fb: Fix printk() style warning

On Thu, Oct 13, 2016 at 05:39:22PM +0300, Mike Rapoport wrote:
> On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote:
> > 
> > Thanks, that makes sense.  I tried deleting the if statement and printk()
> > from ddk750_help.c, and adding the following in lynxfb_pci_probe() after
> > calling hw_sm750_map() and checking for errors:
> > 
> > if (sm750_dev->revid == 0xfe)
> > 	dev_info(&pdev->dev, "found sm750le\n");
> > 
> > The driver compiles, loads and unloads ok with this code.
> > 
> > Does this look correct?
> 
> Yep, seems just right.
>  
> > Regards,
> > Ed L.

Good, thanks.  I will submit an updated patch.

Regards,
Ed L.