linux-kernel - Re: [PATCH] staging: greybus: timesync.c: Fixed WARNING for brace issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 13 Oct 2016 10:12:33 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Chase Metzger <chasemetzger15@...il.com>
Cc:     "Bryan O'Donoghue" <pure.logic@...us-software.ie>,
        driver-dev <devel@...verdev.osuosl.org>,
        Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH] staging: greybus: timesync.c: Fixed WARNING for brace issue

On Thu, Oct 13, 2016 at 1:20 AM, Chase Metzger <chasemetzger15@...il.com> wrote:
> Removed a checkpatch warning for braces on single argument if and else
> statement.
>
> Signed-off-by: Chase Metzger <chasemetzger15@...il.com>
> ---
>  drivers/staging/greybus/timesync.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/timesync.c b/drivers/staging/greybus/timesync.c
> index 2e68af7..e586627 100644
> --- a/drivers/staging/greybus/timesync.c
> +++ b/drivers/staging/greybus/timesync.c
> @@ -807,11 +807,11 @@ static int gb_timesync_schedule(struct gb_timesync_svc *timesync_svc, int state)
>                 return -EINVAL;
>
>         mutex_lock(&timesync_svc->mutex);
> -       if (timesync_svc->state !=  GB_TIMESYNC_STATE_INVALID) {
> +       if (timesync_svc->state !=  GB_TIMESYNC_STATE_INVALID)
>                 gb_timesync_set_state_atomic(timesync_svc, state);
> -       } else {
> +       else
>                 ret = -ENODEV;
> -       }
> +
>         mutex_unlock(&timesync_svc->mutex);
>         return ret;
>  }

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>