linux-kernel - lz4 v lz4hc compression discrepancy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 12 Oct 2016 16:50:56 -0700
From:   Srinath Krishna Ananthakrishnan <ska@...era.io>
To:     linux-kernel@...r.kernel.org
Subject: lz4 v lz4hc compression discrepancy

Hi,

I'm trying to use the lz4 library in the kernel for compression and I
have a case where for a candidate payload worth 16k bytes (attached),
the data that is retrieved after compression + decompression is
different from the original data when using lz4hc. On the other hand,
using the lz4 variant, the data matches perfectly. In both the cases,
I'm using the decompression routine with the known size (16k).

I'm using the kernel version 4.1.26 with just the following commit
backported in the lz4 library from the head kernel.

commit 99b7e93c95c78952724a9783de6c78def8fbfc3f
Author: Krzysztof Kolasa <kkolasa@...soft.pl>
Date:   Sun May 3 22:58:59 2015 -0500

    lz4: fix system halt at boot kernel on x86_64

    Sometimes, on x86_64, decompression fails with the following
    error:

    Decompressing Linux...

    Decoding failed

     -- System halted

    This condition is not needed for a 64bit kernel(from commit d5e7caf):

    if( ... ||
        (op + COPYLENGTH) > oend)
        goto _output_error

    macro LZ4_SECURE_COPY() tests op and does not copy any data
    when op exceeds the value.

    added by analogy to lz4_uncompress_unknownoutputsize(...)

    Signed-off-by: Krzysztof Kolasa <kkolasa@...soft.pl>
    Tested-by: Alexander Kuleshov <kuleshovmail@...il.com>
    Tested-by: Caleb Jorden <cjorden@...il.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Thanks,
Srinath

Download attachment "extent.0" of type "application/octet-stream" (16384 bytes)