[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20161013054211.GA2991@vireshk-i7>
Date: Thu, 13 Oct 2016 11:12:11 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Dave Gerlach <d-gerlach@...com>
Cc: Rafael Wysocki <rjw@...ysocki.net>, nm@...com,
sboyd@...eaurora.org, Viresh Kumar <vireshk@...nel.org>,
linaro-kernel@...ts.linaro.org, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org,
Vincent Guittot <vincent.guittot@...aro.org>, robh@...nel.org,
broonie@...nel.org
Subject: Re: [PATCH 3/8] PM / OPP: Manage supply's voltage/current in a
separate structure
On 12-10-16, 16:15, Dave Gerlach wrote:
> > /**
> >+ * struct dev_pm_opp_supply - Power supply voltage/current values
> >+ * @u_volt: Target voltage in microvolts corresponding to this OPP
> >+ * @u_volt_min: Minimum voltage in microvolts corresponding to thisq OPP
> >+ * @u_volt_max: Maximum voltage in microvolts corresponding to this OPP
> >+ * @u_amp: Maximum current drawn by the device in microamperes
> >+ *
> >+ * This structure stores the voltage/current values for a single power supply.
> >+ */
> >+struct dev_pm_opp_supply {
> >+ unsigned long u_volt;
> >+ unsigned long u_volt_min;
> >+ unsigned long u_volt_max;
> >+ unsigned long u_amp;
> >+};
> >+
> >+/**
>
> This needs to move to include/linux/pm_opp.h, does it not? We need access to
> the actual voltage values from outside of the OPP core if we are going to be
> setting regulators from the platform provided opp_set_rate callback
> described in patch 7.
Yes, will do in V2.
--
viresh
Powered by blists - more mailing lists