linux-kernel - Re: [PATCH v5 2/4] fusion: remove iopriority handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Oct 2016 18:36:32 -0500
From:   Shaun Tancheff <shaun.tancheff@...gate.com>
To:     Adam Manzanares <adam.manzanares@...t.com>
Cc:     Jens Axboe <axboe@...nel.dk>, Tejun Heo <tj@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Hannes Reinecke <hare@...e.de>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Mike Christie <mchristi@...hat.com>,
        Toshi Kani <toshi.kani@....com>,
        Ming Lei <ming.lei@...onical.com>,
        Sathya Prakash <sathya.prakash@...adcom.com>,
        chaitra.basappa@...adcom.com,
        suganath-prabu.subramani@...adcom.com, linux-block@...r.kernel.org,
        linux-ide@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        MPT-FusionLinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        Adam Manzanares <adam.manzanares@....com>
Subject: Re: [PATCH v5 2/4] fusion: remove iopriority handling

On Thu, Oct 13, 2016 at 6:00 PM, Adam Manzanares
<adam.manzanares@...t.com> wrote:
> The request priority is now by default coming from the ioc. It was not
> clear what this code was trying to do based upon the iopriority class or
> data. The driver should check that a device supports priorities and use
> them according to the specificiations of ioprio.
>
> Signed-off-by: Adam Manzanares <adam.manzanares@....com>
> ---
>  drivers/message/fusion/mptscsih.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/message/fusion/mptscsih.c b/drivers/message/fusion/mptscsih.c
> index 6c9fc11..4740bb6 100644
> --- a/drivers/message/fusion/mptscsih.c
> +++ b/drivers/message/fusion/mptscsih.c
> @@ -1369,11 +1369,6 @@ mptscsih_qcmd(struct scsi_cmnd *SCpnt)
>         if ((vdevice->vtarget->tflags & MPT_TARGET_FLAGS_Q_YES)
>             && (SCpnt->device->tagged_supported)) {
>                 scsictl = scsidir | MPI_SCSIIO_CONTROL_SIMPLEQ;
> -               if (SCpnt->request && SCpnt->request->ioprio) {
> -                       if (((SCpnt->request->ioprio & 0x7) == 1) ||
> -                               !(SCpnt->request->ioprio & 0x7))
> -                               scsictl |= MPI_SCSIIO_CONTROL_HEADOFQ;
> -               }
>         } else
>                 scsictl = scsidir | MPI_SCSIIO_CONTROL_UNTAGGED;

Style wise you can further remove the extra parens around
  SCpnt->device->tagged_supported
As well as the now redundant braces.

Regards,
Shaun

> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-block" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_majordomo-2Dinfo.html&d=DQIBAg&c=IGDlg0lD0b-nebmJJ0Kp8A&r=Wg5NqlNlVTT7Ugl8V50qIHLe856QW0qfG3WVYGOrWzA&m=ZE7JzxXeXPEWqk9WYm42hZHj8gESRg1QoS5XklfbprM&s=C0iMyTgYbYl06F1SQ2DqfdESKBtl3Whp5rSnHSBXOc4&e=