linux-kernel - Re: [RFC v2 PATCH] mm/percpu.c: simplify grouping CPU algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Oct 2016 19:37:22 -0400
From:   Tejun Heo <tj@...nel.org>
To:     zijun_hu <zijun_hu@...o.com>
Cc:     akpm@...ux-foundation.org, zijun_hu@....com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, cl@...ux.com
Subject: Re: [RFC v2 PATCH] mm/percpu.c: simplify grouping CPU algorithm

Hello, Zijun.

On Tue, Oct 11, 2016 at 08:48:45PM +0800, zijun_hu wrote:
> compared with the original algorithm theoretically and practically, the
> new one educes the same grouping results, besides, it is more effective,
> simpler and easier to understand.

If the original code wasn't broken and the new code produces the same
output, I'd really not mess with this code.  There simply is no upside
to messing with this code.  It's run once during boot and never a
noticeable contributor of boot overhead.  Maybe the new code is a bit
simpler and more efficient but the actual benefit is so small that any
risk would outweigh it.

Thanks.

-- 
tejun