linux-kernel - Re: [PATCH v2] i2c: i2c-piix4: several coding style fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3c9ba6ec-c137-fa3c-7b5b-7ea7ed58e865@synopsys.com>
Date:   Fri, 14 Oct 2016 12:52:50 +0100
From:   Carlos Palminha <CARLOS.PALMINHA@...opsys.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Carlos Palminha <CARLOS.PALMINHA@...opsys.com>
CC:     <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] i2c: i2c-piix4: several coding style fixes

On 14-10-2016 08:08, Uwe Kleine-König wrote:
> Hello,
>
> On Thu, Oct 13, 2016 at 11:39:01PM +0100, Carlos Palminha wrote:
>> @@ -196,7 +204,7 @@ static int piix4_setup(struct pci_dev *PIIX4_dev,
>>  	} else {
>>  		pci_read_config_word(PIIX4_dev, SMBBA, &piix4_smba);
>>  		piix4_smba &= 0xfff0;
>> -		if(piix4_smba == 0) {
>> +		if (piix4_smba == 0) {
>>  			dev_err(&PIIX4_dev->dev, "SMBus base address "
>>  				"uninitialized - upgrade BIOS or use "
>>  				"force_addr=0xaddr\n");
>
> did you left this message in three lines on purpose?
>
Hi Uwe,

There were some missing lines. I had some doubts regarding if the 
"quoted string" could go with more than 80 chars. I see now that 
checkpatch is ok.

I'll resend a v3.

> Best regards
> Uwe
>

Regards,
C.Palminha