linux-kernel - Re: [PATCH v2] i2c: i2c-piix4: several coding style fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161014070825.qlawh2ttlwj24jge@pengutronix.de>
Date:   Fri, 14 Oct 2016 09:08:25 +0200
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Carlos Palminha <CARLOS.PALMINHA@...opsys.com>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: i2c-piix4: several coding style fixes

Hello,

On Thu, Oct 13, 2016 at 11:39:01PM +0100, Carlos Palminha wrote:
> @@ -196,7 +204,7 @@ static int piix4_setup(struct pci_dev *PIIX4_dev,
>  	} else {
>  		pci_read_config_word(PIIX4_dev, SMBBA, &piix4_smba);
>  		piix4_smba &= 0xfff0;
> -		if(piix4_smba == 0) {
> +		if (piix4_smba == 0) {
>  			dev_err(&PIIX4_dev->dev, "SMBus base address "
>  				"uninitialized - upgrade BIOS or use "
>  				"force_addr=0xaddr\n");

did you left this message in three lines on purpose?

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |