linux-kernel - Re: [PATCH] MIPS: Fix build of compressed image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19710051.vF94pmxeQo@np-p-burton>
Date:   Mon, 17 Oct 2016 16:22:14 +0100
From:   Paul Burton <paul.burton@...tec.com>
To:     <linux-mips@...ux-mips.org>,
        Matt Redfearn <matt.redfearn@...tec.com>
CC:     Ralf Baechle <ralf@...ux-mips.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] MIPS: Fix build of compressed image

On Monday, 17 October 2016 10:09:39 BST Matt Redfearn wrote:
> Changes introduced to arch/mips/Makefile for the generic kernel resulted
> in build errors when making a compressed image if platform-y has multiple
> values, like this:
> 
> make[2]: *** No rule to make target `alchemy/'.
> make[1]: *** [vmlinuz] Error 2
> make[1]: Target `_all' not remade because of errors.
> make: *** [sub-make] Error 2
> make: Target `_all' not remade because of errors.
> 
> Fix this by quoting $(platform-y) as it is passed to the Makefile in
> arch/mips/boot/compressed/Makefile
> 
> Reported-by: kernelci.org bot <bot@...nelci.org>
> Link:
> https://storage.kernelci.org/next/next-20161017/mips-gpr_defconfig/build.lo
> g Signed-off-by: Matt Redfearn <matt.redfearn@...tec.com>
> 
> ---
> 
>  arch/mips/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index fbf40d3c8123..1a6bac7b076f 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -263,7 +263,7 @@ KBUILD_CPPFLAGS += -DDATAOFFSET=$(if
> $(dataoffset-y),$(dataoffset-y),0)
> 
>  bootvars-y	= VMLINUX_LOAD_ADDRESS=$(load-y) \
>  		  VMLINUX_ENTRY_ADDRESS=$(entry-y) \
> -		  PLATFORM=$(platform-y)
> +		  PLATFORM="$(platform-y)"
>  ifdef CONFIG_32BIT
>  bootvars-y	+= ADDR_BITS=32
>  endif

Hi Matt,

Reviewed-by: Paul Burton <paul.burton@...tec.com>

Thanks,
    Paul
Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)