linux-kernel - Re: [PATCH v2 0/3] Coccinelle: misc: Improve the script for more accurate results

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58065376.5020406@oracle.com>
Date:   Tue, 18 Oct 2016 22:23:10 +0530
From:   Vaishali Thakkar <vaishali.thakkar@...cle.com>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     mmarek@...e.com, Gilles.Muller@...6.fr, nicolas.palix@...g.fr,
        cocci@...teme.lip6.fr, linux-kernel@...r.kernel.org,
        lars@...afoo.de
Subject: Re: [PATCH v2 0/3] Coccinelle: misc: Improve the script for more
 accurate results



On Tuesday 18 October 2016 10:04 PM, Julia Lawall wrote:
> I get the following in patch mode that I don't get in context mode:

Hi,

Are you getting same number of devm cases in your report for the context
and patch mode? [except this case]


> diff -u -p a/drivers/power/supply/tps65090-charger.c
> b/drivers/power/supply/tps\
> 65090-charger.c
> --- a/drivers/power/supply/tps65090-charger.c
> +++ b/drivers/power/supply/tps65090-charger.c
> @@ -311,7 +311,8 @@ static int tps65090_charger_probe(struct
> 
> 	if (irq != -ENXIO) {
> 		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> -                       tps65090_charger_isr, 0, "tps65090-charger", cdata);
> +                       tps65090_charger_isr, IRQF_ONESHOT,
> +                       "tps65090-charger", cdata);
> 		if (ret) {
>                         dev_err(cdata->dev,
> 				"Unable to register irq %d err %d\n", irq,
> 
> 
> julia
> 

-- 
Vaishali