linux-kernel - Re: [PATCH v2 0/3] Coccinelle: misc: Improve the script for more accurate results

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1610181859590.2950@hadrien>
Date:   Tue, 18 Oct 2016 19:01:01 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Vaishali Thakkar <vaishali.thakkar@...cle.com>
cc:     Julia Lawall <julia.lawall@...6.fr>, mmarek@...e.com,
        Gilles.Muller@...6.fr, nicolas.palix@...g.fr,
        cocci@...teme.lip6.fr, linux-kernel@...r.kernel.org,
        lars@...afoo.de
Subject: Re: [PATCH v2 0/3] Coccinelle: misc: Improve the script for more
 accurate results



On Tue, 18 Oct 2016, Vaishali Thakkar wrote:

>
>
> On Tuesday 18 October 2016 10:04 PM, Julia Lawall wrote:
> > I get the following in patch mode that I don't get in context mode:
>
> Hi,
>
> Are you getting same number of devm cases in your report for the context
> and patch mode? [except this case]

The only devm case I get in context mode is:

diff -u -p /var/linuxes/linux-next/drivers/acpi/evged.c
/tmp/nothing/drivers/ac\
pi/evged.c
--- /var/linuxes/linux-next/drivers/acpi/evged.c
+++ /tmp/nothing/drivers/acpi/evged.c
@@ -116,8 +116,6 @@ static acpi_status acpi_ged_request_inte
        if (r.flags & IORESOURCE_IRQ_SHAREABLE)
                irqflags |= IRQF_SHARED;

-       if (devm_request_threaded_irq(dev, irq, NULL, acpi_ged_irq_handler,
-                                     irqflags, "ACPI:Ged", event)) {
                dev_err(dev, "failed to setup event handler for irq %u\n", irq);
                return AE_ERROR;
        }

This one has the property that the first argument is an identifier.  The
other cases seem to have a & expression.  There are around 20 of them.

julia



>
>
> > diff -u -p a/drivers/power/supply/tps65090-charger.c
> > b/drivers/power/supply/tps\
> > 65090-charger.c
> > --- a/drivers/power/supply/tps65090-charger.c
> > +++ b/drivers/power/supply/tps65090-charger.c
> > @@ -311,7 +311,8 @@ static int tps65090_charger_probe(struct
> >
> > 	if (irq != -ENXIO) {
> > 		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> > -                       tps65090_charger_isr, 0, "tps65090-charger", cdata);
> > +                       tps65090_charger_isr, IRQF_ONESHOT,
> > +                       "tps65090-charger", cdata);
> > 		if (ret) {
> >                         dev_err(cdata->dev,
> > 				"Unable to register irq %d err %d\n", irq,
> >
> >
> > julia
> >
>
> --
> Vaishali
>