linux-kernel - Re: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161018.143025.284251297276702898.davem@davemloft.net>
Date:   Tue, 18 Oct 2016 14:30:25 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     stefan.wahren@...e.com
Cc:     gregkh@...uxfoundation.org, jslaby@...e.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver

From: Stefan Wahren <stefan.wahren@...e.com>
Date: Tue, 18 Oct 2016 13:27:34 +0200

> +void
> +qca_tty_receive(struct tty_struct *tty, const unsigned char *cp, char *fp,
> +		int count)
> +{
> +	struct qcauart *qca = tty->disc_data;
> +	struct net_device_stats *n_stats = &qca->net_dev->stats;
> +	int dropped = 0;

Please order local variable declarations from longest to shortest line.

> +netdev_tx_t
> +qcauart_netdev_xmit(struct sk_buff *skb, struct net_device *dev)
> +{
> +	struct qcauart *qca = netdev_priv(dev);
> +	struct net_device_stats *n_stats = &dev->stats;
> +	u8 *pos;
> +	u8 pad_len = 0;
> +	int written;

Likewise.