linux-kernel - Re: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <acda56ec-75c2-9753-710e-d69b36f88095@i2se.com>
Date:   Fri, 21 Oct 2016 13:38:17 +0200
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     David Miller <davem@...emloft.net>
Cc:     gregkh@...uxfoundation.org, jslaby@...e.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver

Am 18.10.2016 um 20:30 schrieb David Miller:
> From: Stefan Wahren <stefan.wahren@...e.com>
> Date: Tue, 18 Oct 2016 13:27:34 +0200
>
>> +void
>> +qca_tty_receive(struct tty_struct *tty, const unsigned char *cp, char *fp,
>> +		int count)
>> +{
>> +	struct qcauart *qca = tty->disc_data;
>> +	struct net_device_stats *n_stats = &qca->net_dev->stats;
>> +	int dropped = 0;
> Please order local variable declarations from longest to shortest line.

Even if the current second init depends on the first one?