linux-kernel - Re: [media] winbond-cir: Move a variable assignment in wbcir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db564db599ac11c5b191d6ec3eec32ff@hardeman.nu>
Date:   Wed, 19 Oct 2016 13:47:01 +0000
From:   "David Härdeman" <david@...deman.nu>
To:     "SF Markus Elfring" <elfring@...rs.sourceforge.net>,
        linux-media@...r.kernel.org
Cc:     "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Sean Young" <sean@...s.org>,
        "LKML" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        "Julia Lawall" <julia.lawall@...6.fr>
Subject: Re: [media] winbond-cir: Move a variable assignment in wbcir_tx()

October 19, 2016 3:32 PM, "SF Markus Elfring" <elfring@...rs.sourceforge.net> wrote:
>>> Move the assignment for the local variable "data" behind the source code
>>> for a memory allocation by this function.
>> 
>> Sorry, I can't see what the point is?
> 
> * How do you think about to avoid a variable assignment in case
> that this memory allocation failed anyhow?

There is no memory allocation that can fail at this point.

> * Do you care for data access locality?

Not unless you can show measurable performance improvements?