linux-kernel - Re: [RESEND][PATCHv2] cpupower: Correct return type of cpu_power_is_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <331512cb-ccfb-a9eb-fea8-501fa333920c@linux.vnet.ibm.com>
Date:   Thu, 20 Oct 2016 13:42:49 +0530
From:   Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>
To:     Laura Abbott <labbott@...hat.com>,
        Thomas Renninger <trenn@...e.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [RESEND][PATCHv2] cpupower: Correct return type of
 cpu_power_is_cpu_online in cpufreq



On 10/20/2016 04:23 AM, Laura Abbott wrote:
> When converting to a shared library in ac5a181d065d ("cpupower: Add
> cpuidle parts into library"), cpu_freq_cpu_exists was converted to
> cpupower_is_cpu_online. cpu_req_cpu_exists returned 0 on success and
> -ENOSYS on failure whereas cpupower_is_cpu_online returns 1 on success.
> Check for the correct return value in cpufreq-set.
> 
> See https://bugzilla.redhat.com/show_bug.cgi?id=1374212
> 
> Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
> Reported-by: Julian Seward <jseward@....org>
> Signed-off-by: Laura Abbott <labbott@...hat.com>
> ---
> v2: Drop another redundant cpupower_is_cpu_online

Reviewed-by:Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>