linux-kernel - Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00cca626-0444-1ee9-f906-ffd3ae38e79a@gmail.com>
Date:   Thu, 20 Oct 2016 19:16:20 +0700
From:   Ivan Safonov <insafonov@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        Geliang Tang <geliangtang@....com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/37] staging:r8188eu: remove device assignment after
 netdev_alloc_skb call

Andy,
thank you for reviewing patches and tips.

On 10/19/2016 11:59 PM, Andy Shevchenko wrote:
> On Wed, 2016-10-19 at 19:53 +0300, Andy Shevchenko wrote:
>> On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote:
>>>
>>> netdev_alloc_skb function
>>> already set dev member of pkt_copy.
>>
>> It might be one line.
>>
>> Some special references:
>> functions: function()
>> structs: struct my_struct
>>
>> P.S. Entire series lacks of cover letter.
>
> And couple more things:
>  - Use min percentage when run git format-patch to avoid inclusion non-
> maintainers / non-active developers
>  - Adjust your commit messages to be a bit more verbose and put
> explanation "why you create the patch" before "what is done in the
> patch".
>
>>
>>>
>>>
>>> Signed-off-by: Ivan Safonov <insafonov@...il.com>
>>> ---
>>>  drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
>>> b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
>>> index 34198fe..f19b203 100644
>>> --- a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
>>> +++ b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
>>> @@ -123,7 +123,6 @@ static int recvbuf2recvframe(struct adapter
>>> *adapt, struct sk_buff *pskb)
>>>
>>>  		pkt_copy = netdev_alloc_skb(adapt->pnetdev,
>>> alloc_sz);
>>>  		if (pkt_copy) {
>>> -			pkt_copy->dev = adapt->pnetdev;
>>>  			precvframe->pkt = pkt_copy;
>>>  			precvframe->rx_head = pkt_copy->data;
>>>  			precvframe->rx_end = pkt_copy->data +
>>> alloc_sz;
>>
>