linux-kernel - Re: [PATCH 17/37] staging:r8188eu: update pkt->data synchronously with rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cde5b1f0-6752-b826-30cf-f817d25b7b36@gmail.com>
Date:   Thu, 20 Oct 2016 20:15:57 +0700
From:   Ivan Safonov <insafonov@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        Geliang Tang <geliangtang@....com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 17/37] staging:r8188eu: update pkt->data synchronously
 with rx_data

On 10/20/2016 04:03 PM, Dan Carpenter wrote:
> On Wed, Oct 19, 2016 at 10:07:45PM +0700, Ivan Safonov wrote:
>> To replace rx_data with pkt->data.
>> Now pkt->data is equal to rx_data.
>>
>
> I'm not smart enough to tell on my own...  Is this a bugfix?

It is not bugfix, only variable replacement.
recv_frame structure duplicates sk_buff. Most of the ieee80211_* 
functions require a pointer to sk_buff. Therefore, easier to use sk_buff 
instead of recv_frame structure.

>
> regards,
> dan carpenter
>