linux-kernel - Re: [PATCH v2 0/8] mm/swap: Regular page swap optimizations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ffa08555-c170-7c6b-0c7e-798e9988adba@de.ibm.com>
Date:   Fri, 21 Oct 2016 12:05:19 +0200
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     Tim Chen <tim.c.chen@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Ying Huang <ying.huang@...el.com>, dave.hansen@...el.com,
        ak@...ux.intel.com, aaron.lu@...el.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Hugh Dickins <hughd@...gle.com>,
        Shaohua Li <shli@...nel.org>, Minchan Kim <minchan@...nel.org>,
        Rik van Riel <riel@...hat.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Vladimir Davydov <vdavydov.dev@...il.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...nel.org>,
        Hillf Danton <hillf.zj@...baba-inc.com>
Subject: Re: [PATCH v2 0/8] mm/swap: Regular page swap optimizations

On 10/21/2016 10:16 AM, Christian Borntraeger wrote:
> On s390 4.9-rc1 + this patch set
> I get the following on swapon
> 
> [  308.206195] ------------[ cut here ]------------
> [  308.206203] WARNING: CPU: 5 PID: 20745 at mm/page_alloc.c:3511 __alloc_pages_nodemask+0x884/0xdf8
> [  308.206205] Modules linked in: xt_CHECKSUM iptable_mangle ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT nf_reject_ipv4 bridge stp llc ebtable_filter ebtables ip6table_filter ip6_tables iptable_filter btrfs raid6_pq xor dm_service_time ghash_s390 prng aes_s390 des_s390 des_generic qeth_l2 sha512_s390 sha256_s390 sha1_s390 sha_common nfsd eadm_sch auth_rpcgss qeth ccwgroup oid_registry nfs_acl lockd grace vhost_net vhost sunrpc macvtap macvlan kvm sch_fq_codel dm_multipath ip_tables
> [  308.206240] CPU: 5 PID: 20745 Comm: swapon Tainted: G        W       4.9.0-rc1+ #23
> [  308.206241] Hardware name: IBM              2964 NC9              704              (LPAR)
> [  308.206243] task: 00000000e3bb8000 task.stack: 00000000d4270000
> [  308.206244] Krnl PSW : 0704c00180000000 000000000025db3c
> [  308.206246]  (__alloc_pages_nodemask+0x884/0xdf8)
> 
> [  308.206248]            R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:0 PM:0
> [  308.206250]  RI:0 EA:3
> [  308.206251] 
>                Krnl GPRS: 000000000000000a 0000000000b2b0ec 0000000100000312 0000000000000001
> [  308.206267]            000000000025d3ec 0000000000000008 0000000000000075 000000000240c0c0
> [  308.206269]            0000000000000001 0000000000000000 000000000000000a 0000000000000000
> [  308.206270]            000000000000000a 000000000079d8c8 000000000025d3ec 00000000d4273ba0
> [  308.206280] Krnl Code: 000000000025db30: a774fd27		brc	7,25d57e
> [  308.206282] 
>                           000000000025db34: 92011000		mvi	0(%r1),1
> [  308.206285] 
>                          #000000000025db38: a7f40001		brc	15,25db3a
> [  308.206286] 
>                          >000000000025db3c: a7f4fd21		brc	15,25d57e
> [  308.206289] 
>                           000000000025db40: 4130f150		la	%r3,336(%r15)
> [  308.206291] 
>                           000000000025db44: b904002c		lgr	%r2,%r12
> [  308.206293] 
>                           000000000025db48: c0e5ffffe11c	brasl	%r14,259d80
> [  308.206294] 
>                           000000000025db4e: a7f4fda3		brc	15,25d694
> [  308.206297] Call Trace:
> [  308.206299] ([<000000000025d3ec>] __alloc_pages_nodemask+0x134/0xdf8)
> [  308.206303] ([<0000000000280d6a>] kmalloc_order+0x42/0x70)
> [  308.206305] ([<0000000000280dd8>] kmalloc_order_trace+0x40/0xf0)
> [  308.206310] ([<00000000002a7090>] init_swap_address_space+0x68/0x138)
> [  308.206312] ([<00000000002ac858>] SyS_swapon+0xbd0/0xf80)
> [  308.206317] ([<0000000000785476>] system_call+0xd6/0x264)
> [  308.206318] Last Breaking-Event-Address:
> [  308.206319]  [<000000000025db38>] __alloc_pages_nodemask+0x880/0xdf8
> [  308.206320] ---[ end trace aaeca736f47ac05b ]---
> 

Looks like that 1TB of swap is just too big for your logic (you try kmalloc without checking the size).