linux-kernel - Re: [PATCH v2] x86/entry64: remove unused audit related macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161023133310.hq24zte6n3qqe4f4@pd.tnic>
Date:   Sun, 23 Oct 2016 15:33:10 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Alexander Kuleshov <kuleshovmail@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86/entry64: remove unused audit related macros

On Sun, Oct 23, 2016 at 07:14:36PM +0600, Alexander Kuleshov wrote:
> These macro ocured in the 86a1c34a929f commit (x86_64 syscall audit
> fast-path by Roland McGrath <roland@...hat.com>).
> 
> These defines were used in two-phase sycalls entry tracing, but
> this functionality was moved to the syscall_trace_enter() from
> arch/x86/entry/common.c in the 1f484aa69 commit (x86/entry: Move
> C entry and exit code to arch/x86/entry/common.c by Andy Lutomirski
> <luto@...nel.org>).
> 
> The syscall_trace_enter() now uses same defines from <linux/audit.h>,
> so these defines are no longer used anywhere in entry_64.S and we may
> remove them.

Good, it is getting there. Very close to what I had in mind, thanks!

Now, I went and made it a bit more readable and put the commit IDs and
their names on separate lines, like we do in tip:

"These macros were added in commit

  86a1c34a929f ("x86_64 syscall audit fast-path").

They were used for sycalls auditing, but this functionality was moved to
the arch/x86/entry/common.c:syscall_trace_enter() in

  1f484aa69046 ("x86/entry: Move C entry and exit code to arch/x86/entry/common.c")

syscall_trace_enter() now uses the same defines from <linux/audit.h>,
so these defines are no longer used anywhere in entry_64.S and we may
remove them."

Also, we abbreviate git commits to 12 chars. What you could do is add
this to your .gitconfig:

[alias]
        one = show -s --pretty='format:%h (\"%s\")'

and then simply do

$ git one 1f484aa69

and it'll format it properly for ya.

Anyway, just a couple of things to pay attention to in the future.

With this, you can add

Reviewed-by: Borislav Petkov <bp@...e.de>

to your v3.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.