linux-kernel - Re: [PATCH v3 3/6] pwm: imx: support output polarity inversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161023084027.4a2aae51@jawa>
Date:   Sun, 23 Oct 2016 08:40:27 +0200
From:   Lukasz Majewski <l.majewski@...ess.pl>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:     Stefan Agner <stefan@...er.ch>, thierry.reding@...il.com,
        mark.rutland@....com, linux-pwm@...r.kernel.org,
        Bhuvanchandra DV <bhuvanchandra.dv@...adex.com>,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        kernel@...gutronix.de, fabio.estevam@....com, shawnguo@...nel.org,
        linux-arm-kernel@...ts.infradead.org,
        Lothar Wassmann <LW@...o-electronics.de>
Subject: Re: [PATCH v3 3/6] pwm: imx: support output polarity inversion

Hi Boris,

> > 
> > Could you be more specific here? 
> > 
> > As I mentioned before, the problem is not with the lack of
> > "atomic" API.  
> 
> Below is a quick and dirty I made on top of this patch to show you how
> atomic update can be implemented in this driver. 

Thank you for example patch.

I will implement the ->apply() callback and post patches very soon :-).

I had two issues with the ->apply() implementation:

- Do my work on top of this patch (https://lkml.org/lkml/2016/10/7/454
  as you did) to avoid rewriting work already done.

- In the example ->apply() implementation for rockchip
  (https://patchwork.kernel.org/patch/7228221/) the ->config() callback
  was not removed when ->apply() was implemented. I was confused with
  such approach, but as you explained in this mail, the solely ->apply()
  is enough.

> It's not tested, and
> probably not working, but it should give you a better idea of what is
> expected.

Thanks for explanation,

Łukasz Majewski

Content of type "application/pgp-signature" skipped