linux-kernel - Re: [PATCH 2/2] mailbox: sti: Fix module autoload for OF registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161024091115.GG14477@dell>
Date:   Mon, 24 Oct 2016 10:11:15 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org, Jassi Brar <jassisinghbrar@...il.com>
Subject: Re: [PATCH 2/2] mailbox: sti: Fix module autoload for OF registration

On Thu, 20 Oct 2016, Javier Martinez Canillas wrote:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/mailbox/mailbox-sti.ko | grep alias
> alias:          platform:mailbox-sti
> 
> After this patch:
> 
> $ modinfo drivers/mailbox/mailbox-sti.ko | grep alias
> alias:          platform:mailbox-sti
> alias:          of:N*T*Cst,stih407-mailboxC*
> alias:          of:N*T*Cst,stih407-mailbox
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> 
> ---
> 
>  drivers/mailbox/mailbox-sti.c | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Lee Jones <lee.jones@...aro.org>

> diff --git a/drivers/mailbox/mailbox-sti.c b/drivers/mailbox/mailbox-sti.c
> index a334db5c9f1c..41bcd339b68a 100644
> --- a/drivers/mailbox/mailbox-sti.c
> +++ b/drivers/mailbox/mailbox-sti.c
> @@ -403,6 +403,7 @@ static const struct of_device_id sti_mailbox_match[] = {
>  	},
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, sti_mailbox_match);
>  
>  static int sti_mbox_probe(struct platform_device *pdev)
>  {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog