linux-kernel - Re: [PATCH 1/2] mailbox: mailbox-test: Fix module autoload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d940511-cb29-9b0b-b3b0-e24447a18206@osg.samsung.com>
Date:   Tue, 29 Nov 2016 11:53:07 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Jassi Brar <jassisinghbrar@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mailbox: mailbox-test: Fix module autoload

Hello Jessi,

On 10/24/2016 06:10 AM, Lee Jones wrote:
> On Thu, 20 Oct 2016, Javier Martinez Canillas wrote:
> 
>> If the driver is built as a module, autoload won't work because the module
>> alias information is not filled. So user-space can't match the registered
>> device with the corresponding module.
>>
>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>
>> Before this patch:
>>
>> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
>> $
>>
>> After this patch:
>>
>> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
>> alias:          of:N*T*Cmailbox-testC*
>> alias:          of:N*T*Cmailbox-test
>>
>> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>> ---
>>
>>  drivers/mailbox/mailbox-test.c | 1 +
>>  1 file changed, 1 insertion(+)
> 
> Acked-by: Lee Jones <lee.jones@...aro.org>
> 

Any comments about this patch and 2/2? Lee acked both patches but
I see that were never picked.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America