linux-kernel - Re: [PATCH v3] pinctrl: Add SX150X GPIO Extender Pinctrl Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY7vLU4yVP7M-O4rGt_L5cqL57ApmMQJ4aRGgzh3Nat6Q@mail.gmail.com>
Date:   Mon, 24 Oct 2016 16:39:17 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andrey Smirnov <andrew.smirnov@...il.com>,
        Neil Armstrong <narmstrong@...libre.com>
Cc:     Peter Rosin <peda@...ntia.se>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Roland Stigge <stigge@...com.de>,
        Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
Subject: Re: [PATCH v3] pinctrl: Add SX150X GPIO Extender Pinctrl Driver

On Mon, Oct 24, 2016 at 6:51 AM, Andrey Smirnov
<andrew.smirnov@...il.com> wrote:

> It seem strange to me that the driver uses "handle_edge_irq", given
> how none of the individual interrupts seem to require any ACKing,
> since it is all handled in sx150x_irq_thread_fn(), line 533. More so,
> I had trouble finding who/where sets .irq_ack() callback, which AFAIU
> is mandatory for handle_edge_irq().

Yes that looks strange.

Neil have you tested IRQs with this code?

If there is trouble, please follow up with a fix for the edge handler.
Maybe it should just be handle_simple_irq().

Yours,
Linus Walleij