linux-kernel - Re: [PATCH] ARC: return -EFAULT on failed access_ok for arc_usr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92d0dd5e-8aa8-3e55-193f-1fa440cb3ff3@synopsys.com>
Date:   Mon, 24 Oct 2016 08:56:48 -0700
From:   Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:     Colin King <colin.king@...onical.com>, Jiri Slaby <jslaby@...e.cz>,
        Andrew Morton <akpm@...ux-foundation.org>,
        <linux-snps-arc@...ts.infradead.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARC: return -EFAULT on failed access_ok for
 arc_usr_cmpxchg syscall

On 10/24/2016 03:47 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> arc_usr_cmpxchg currently returns an uninitialized value in ret
> on a failed access_ok call. Instead, return -EFAULT.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  arch/arc/kernel/process.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arc/kernel/process.c b/arch/arc/kernel/process.c
> index a746008..9ae3e1c 100644
> --- a/arch/arc/kernel/process.c
> +++ b/arch/arc/kernel/process.c
> @@ -47,7 +47,7 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, expected, int, new)
>  	int ret;
>  
>  	if (!access_ok(VERIFY_WRITE, uaddr, sizeof(int)))
> -		return ret;
> +		return -EFAULT;
>  
>  	preempt_disable();

Thx for spotting this. Since this is new code, not yet merged, do you mind if I
squash it with orig patch. I can add a Reviewed-by a SOB as you prefer.

Thx,
-Vineet