linux-kernel - Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3749845.re3cZTKYeA@wuerfel>
Date:   Mon, 24 Oct 2016 21:49:12 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Alex Deucher <alexdeucher@...il.com>
Cc:     Baoyou Xie <baoyou.xie@...aro.org>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        Dave Airlie <airlied@...ux.ie>, Rex Zhu <Rex.Zhu@....com>,
        "Zhou, Jammy" <Jammy.Zhou@....com>,
        Eric Huang <JinHuiEric.Huang@....com>,
        Tom St Denis <tom.stdenis@....com>,
        Edward O'Callaghan <funfunctor@...klore1984.net>,
        Vitaly Prosyak <vitaly.prosyak@....com>,
        Eric Yang <eric.yang2@....com>, yanyang1 <Young.Yang@....com>,
        Huang Rui <ray.huang@....com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Flora Cui <Flora.Cui@....com>,
        Nils Wallménius <nils.wallmenius@...il.com>,
        "monk.liu" <Monk.Liu@....com>, Ken Wang <Qingqing.Wang@....com>,
        "Min, Frank" <Frank.Min@....com>, tang.qiang007@....com.cn,
        xie.baoyou@....com.cn, LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, han.fei@....com.cn
Subject: Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

On Monday, October 24, 2016 12:36:52 PM CEST Alex Deucher wrote:
> On Sat, Oct 22, 2016 at 4:56 AM, Baoyou Xie <baoyou.xie@...aro.org> wrote:
> > We get a few warnings when building kernel with W=1:
> > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:162:5: warning: no previous prototype for 'fiji_setup_pwr_virus' [-Wmissing-prototypes]
> > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smc.c:2052:5: warning: no previous prototype for 'fiji_program_mem_timing_parameters' [-Wmissing-prototypes]
> > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/polaris10_smumgr.c:175:5: warning: no previous prototype for 'polaris10_avfs_event_mgr' [-Wmissing-prototypes]
> > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/cz_hwmgr.c:1020:5: warning: no previous prototype for 'cz_tf_reset_acp_boot_level' [-Wmissing-prototypes]
> > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:92:26: warning: no previous prototype for 'cast_phw_smu7_power_state' [-Wmissing-prototypes]
> > ....
> >
> > In fact, these functions are only used in the file in which they are
> > declared and don't need a declaration, but can be made static.
> > So this patch marks these functions with 'static'.
> >
> > Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> 
> This was already applied the last time you sent it out.  Sorry if I
> didn't mention that previously.

For some reason the patch hasn't made it into linux-next, so I can see
why Baoyou was getting confused here. Can you clarify what the timeline
is for the AMD DRM driver patches from between they get applied to the
AMD tree to when they make it into linux-next?

I've occasionally had a hard time with DRM (and a few other subsystems)
with bugfix patches trying to find out whether they got lost or
whether they just haven't made it into -next but are in some other tree.

Baoyou, when you resend a patch, please try to list explicitly why
you are resending it, when it was last sent, and what kind of reply
you got (integrating any Ack, listing what changes you did, and
if there are no other changes, why you think you have to resend it).

	Arnd