linux-kernel - Re: [PATCH 11/14] staging: fsl-mc: message cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161025074746.GC22581@kroah.com>
Date:   Tue, 25 Oct 2016 09:47:46 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Stuart Yoder <stuart.yoder@....com>
Cc:     german.rivera@....com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, agraf@...e.de, arnd@...db.de,
        leoyang.li@....com
Subject: Re: [PATCH 11/14] staging: fsl-mc: message cleanup

On Mon, Oct 17, 2016 at 01:43:39PM -0500, Stuart Yoder wrote:
> Cleanup and clarify messages
>   -use "fsl-mc" prefix for all messages that don't come from dev_*
>    functions

Nope, please use the proper pr_fmt() #define at the top of the file,
that way you don't have to put the string into all pr_* calls.

>   -remove unnecessary verbosity to make things clearer
>   -use explicit __func__ arguments to clarify some error messages
>   -improve misc wording for clarity

That's alot of different things.  Again, if you have to list the
different things you do in a patch, that means you should break it up
into smaller ones.  Yes, this is a "tiny" patch, but I can't take it
because of the above problem, while if you had broken it up into smaller
ones, I could have taken all but the pr_* changes :(

thanks,

greg k-h