linux-kernel - Re: [PATCH 1/2] Input: fsl-imx25-tcq - fix module autoload when registered via OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161026234633.GG27930@dtor-ws>
Date:   Wed, 26 Oct 2016 16:46:33 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org, Juergen Borleis <jbe@...gutronix.de>,
        linux-input@...r.kernel.org, Markus Pargmann <mpa@...gutronix.de>,
        Lee Jones <lee.jones@...aro.org>,
        Denis Carikli <denis@...rea.com>
Subject: Re: [PATCH 1/2] Input: fsl-imx25-tcq - fix module autoload when
 registered via OF

On Fri, Oct 14, 2016 at 01:00:18PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/input/touchscreen/fsl-imx25-tcq.ko | grep alias
> 
> After this patch:
> 
> $ modinfo drivers/input/touchscreen/fsl-imx25-tcq.ko | grep alias
> alias:          of:N*T*Cfsl,imx25-tcqC*
> alias:          of:N*T*Cfsl,imx25-tcq
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

Applied, thank you.

> ---
> 
>  drivers/input/touchscreen/fsl-imx25-tcq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/fsl-imx25-tcq.c b/drivers/input/touchscreen/fsl-imx25-tcq.c
> index fe9877a6af9e..d50ee490c9cc 100644
> --- a/drivers/input/touchscreen/fsl-imx25-tcq.c
> +++ b/drivers/input/touchscreen/fsl-imx25-tcq.c
> @@ -55,6 +55,7 @@ static const struct of_device_id mx25_tcq_ids[] = {
>  	{ .compatible = "fsl,imx25-tcq", },
>  	{ /* Sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, mx25_tcq_ids);
>  
>  #define TSC_4WIRE_PRE_INDEX 0
>  #define TSC_4WIRE_X_INDEX 1
> -- 
> 2.7.4
> 

-- 
Dmitry