linux-kernel - Re: [PATCH 2/2] Input: da9063 - fix module autoload when registered via OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161026234657.GH27930@dtor-ws>
Date:   Wed, 26 Oct 2016 16:46:57 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org,
        Support Opensource <support.opensource@...semi.com>,
        linux-input@...r.kernel.org
Subject: Re: [PATCH 2/2] Input: da9063 - fix module autoload when registered
 via OF

On Fri, Oct 14, 2016 at 01:00:19PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/input/misc/da9063_onkey.ko | grep alias
> alias:          platform:da9063-onkey
> 
> After this patch:
> 
> $ modinfo drivers/input/misc/da9063_onkey.ko | grep alias
> alias:          platform:da9063-onkey
> alias:          of:N*T*Cdlg,da9062-onkeyC*
> alias:          of:N*T*Cdlg,da9062-onkey
> alias:          of:N*T*Cdlg,da9063-onkeyC*
> alias:          of:N*T*Cdlg,da9063-onkey
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

Applied, thank you.

> ---
> 
>  drivers/input/misc/da9063_onkey.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
> index bb863e062b03..f0d0543562df 100644
> --- a/drivers/input/misc/da9063_onkey.c
> +++ b/drivers/input/misc/da9063_onkey.c
> @@ -87,6 +87,7 @@ static const struct of_device_id da9063_compatible_reg_id_table[] = {
>  	{ .compatible = "dlg,da9062-onkey", .data = &da9062_regs },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, da9063_compatible_reg_id_table);
>  
>  static void da9063_poll_on(struct work_struct *work)
>  {
> -- 
> 2.7.4
> 

-- 
Dmitry