linux-kernel - Re: [PATCH V2 1/3] mfd: wm8994-core: don't split lines unnecessarily

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Oct 2016 13:20:31 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     linaro-kernel@...ts.linaro.org, Mark Brown <broonie@...nel.org>,
        Krzysztof Kozłowski <k.kozlowski@...sung.com>,
        Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
        patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/3] mfd: wm8994-core: don't split lines unnecessarily

On Fri, 16 Sep 2016, Viresh Kumar wrote:

> These can fit in a single line (80 columns), don't split lines
> unnecessarily.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> 
> ---
> V1->V2: New patch
> ---
>  drivers/mfd/wm8994-core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c
> index 7eec619a6023..1990b2c90732 100644
> --- a/drivers/mfd/wm8994-core.c
> +++ b/drivers/mfd/wm8994-core.c
> @@ -401,8 +401,7 @@ static int wm8994_device_init(struct wm8994 *wm8994, int irq)
>  		goto err;
>  	}
>  
> -	ret = regulator_bulk_enable(wm8994->num_supplies,
> -				    wm8994->supplies);
> +	ret = regulator_bulk_enable(wm8994->num_supplies, wm8994->supplies);
>  	if (ret != 0) {
>  		dev_err(wm8994->dev, "Failed to enable supplies: %d\n", ret);
>  		goto err;
> @@ -606,8 +605,7 @@ static void wm8994_device_exit(struct wm8994 *wm8994)
>  	pm_runtime_disable(wm8994->dev);
>  	mfd_remove_devices(wm8994->dev);
>  	wm8994_irq_exit(wm8994);
> -	regulator_bulk_disable(wm8994->num_supplies,
> -			       wm8994->supplies);
> +	regulator_bulk_disable(wm8994->num_supplies, wm8994->supplies);
>  }
>  
>  static const struct of_device_id wm8994_of_match[] = {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog