linux-kernel - Re: [PATCH 11/13] ALSA: Deletion of checks before the function call "iounmap"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161026124245.GR4418@mwanda>
Date:   Wed, 26 Oct 2016 15:42:45 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        Jaroslav Kysela <perex@...ex.cz>,
        Clemens Ladisch <clemens@...isch.de>,
        Russell King <linux@....linux.org.uk>,
        Takashi Iwai <tiwai@...e.de>,
        Thibaut Varene <T-Bone@...isc-linux.org>,
        alsa-devel@...a-project.org, linuxppc-dev@...ts.ozlabs.org,
        linux-parisc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH 11/13] ALSA: Deletion of checks before the function call
 "iounmap"

On Wed, Oct 26, 2016 at 02:28:59PM +0200, Johannes Berg wrote:
> On Wed, 2016-10-26 at 15:26 +0300, Dan Carpenter wrote:
> > Someone was just mentioning in another thread that removing the check
> > from iounmap() is not portable to other arches and then I remembered
> > that Markus removed a bunch of these.
> > 
> > We should consider reverting this, perhaps?
> 
> Can't we teach all architectures? Not that reverting it would be a
> problem.

We probably should.  I just didn't want to suggest it, in case it sounds
like volunteering...  I'm not going to be able to do it because I'm on
the road for a bit.

regards,
dan carpenter