linux-kernel - Re: [PATCH 11/13] ALSA: Deletion of checks before the function call "iounmap"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1477484939.4059.35.camel@sipsolutions.net>
Date:   Wed, 26 Oct 2016 14:28:59 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Jaroslav Kysela <perex@...ex.cz>,
        Clemens Ladisch <clemens@...isch.de>,
        Russell King <linux@....linux.org.uk>,
        Takashi Iwai <tiwai@...e.de>,
        Thibaut Varene <T-Bone@...isc-linux.org>,
        alsa-devel@...a-project.org, linuxppc-dev@...ts.ozlabs.org,
        linux-parisc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH 11/13] ALSA: Deletion of checks before the function call
 "iounmap"

On Wed, 2016-10-26 at 15:26 +0300, Dan Carpenter wrote:
> Someone was just mentioning in another thread that removing the check
> from iounmap() is not portable to other arches and then I remembered
> that Markus removed a bunch of these.
> 
> We should consider reverting this, perhaps?

Can't we teach all architectures? Not that reverting it would be a
problem.

johannes