linux-kernel - Re: [LEDE-DEV] [PATCH] initramfs: Escape colons in depfile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dbcdc8cc-a383-148a-48bc-52abf0de24bb@phrozen.org>
Date:   Thu, 27 Oct 2016 12:35:30 +0200
From:   John Crispin <john@...ozen.org>
To:     Michal Marek <mmarek@...e.com>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     openwrt-devel@...ts.openwrt.org, lede-dev@...ts.infradead.org,
        sam@...nborg.org, linux-kernel@...r.kernel.org
Subject: Re: [LEDE-DEV] [PATCH] initramfs: Escape colons in depfile

Hi,

this seems to be a backport for the kernel tree. please resend it as a
patch adding the actual patch that is being backported to the generic
targets patch folder. this would need to be done for 3.18, 4.1 and 4.4

	John

On 23/09/2016 10:35, Michal Marek wrote:
> Special characters are problematic in depfiles, but we can fix colons
> easily.
> 
> Reported-by: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Michal Marek <mmarek@...e.com>
> ---
>  scripts/gen_initramfs_list.sh | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/gen_initramfs_list.sh b/scripts/gen_initramfs_list.sh
> index 17fa901418ae..0055b07b03b6 100755
> --- a/scripts/gen_initramfs_list.sh
> +++ b/scripts/gen_initramfs_list.sh
> @@ -97,7 +97,10 @@ print_mtime() {
>  }
>  
>  list_parse() {
> -	[ ! -L "$1" ] && echo "$1 \\" || :
> +	if [ -L "$1" ]; then
> +		return
> +	fi
> +	echo "$1" | sed 's/:/\\:/g; s/$/ \\/'
>  }
>  
>  # for each file print a line in following format
>