linux-kernel - RE: [PATCH 2/2] regmap: Avoid namespace collision within macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SG2PR06MB1038CE3B1E2B231A223E5D06C3AA0@SG2PR06MB1038.apcprd06.prod.outlook.com>
Date:   Thu, 27 Oct 2016 10:22:01 +0000
From:   Ramesh Shanmugasundaram <ramesh.shanmugasundaram@...renesas.com>
To:     Mark Brown <broonie@...nel.org>
CC:     "mattw@...eaurora.org" <mattw@...eaurora.org>,
        "mitchelh@...eaurora.org" <mitchelh@...eaurora.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>
Subject: RE: [PATCH 2/2] regmap: Avoid namespace collision within macro

> On Thu, Oct 27, 2016 at 10:33:19AM +0100, Ramesh Shanmugasundaram wrote:
> 
> >  #define regmap_read_poll_timeout(map, addr, val, cond, sleep_us,
> > timeout_us) \  ({ \
> > -	ktime_t timeout = ktime_add_us(ktime_get(), timeout_us); \
> > +	ktime_t __timeout = ktime_add_us(ktime_get(), timeout_us); \
> >  	int ret; \
> 
> Why is timeout an issue and not ret?

It is! However, it is less likely for someone to use "ret" as a variable name for the given parameter list. Hence, I fixed timeout alone. Feel free to fix "ret" as well. 

Thanks,
Ramesh