[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1477756163.8025.0.camel@linux.intel.com>
Date: Sat, 29 Oct 2016 08:49:23 -0700
From: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Borislav Petkov <bp@...en8.de>, LKML <linux-kernel@...r.kernel.org>
Cc: Jiri Kosina <jikos@...nel.org>,
Benjamin Tissoires <benjamin.tissoires@...hat.com>,
Wei Yongjun <weiyongjun1@...wei.com>,
linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: intel-ish-hid: Fix !CONFIG_PM build warning
On Sat, 2016-10-29 at 13:17 +0200, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
>
> Fix
>
> drivers/hid/intel-ish-hid/ipc/pci-ish.c:247:12: warning:
> ‘ish_suspend’ defined but not used [-Wunused-function]
> static int ish_suspend(struct device *device)
> ^
> drivers/hid/intel-ish-hid/ipc/pci-ish.c:282:12: warning:
> ‘ish_resume’ defined but not used [-Wunused-function]
> static int ish_resume(struct device *device)
> ^
> by sticking them in the CONFIG_PM range too.
>
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> Cc: Wei Yongjun <weiyongjun1@...wei.com>
> Cc: linux-input@...r.kernel.org
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>-
> ---
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> index 42f0beeb09fd..7e3622a724aa 100644
> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> @@ -202,6 +202,7 @@ static void ish_remove(struct pci_dev *pdev)
> kfree(ishtp_dev);
> }
>
> +#ifdef CONFIG_PM
> static struct device *ish_resume_device;
>
> /**
> @@ -293,7 +294,6 @@ static int ish_resume(struct device *device)
> return 0;
> }
>
> -#ifdef CONFIG_PM
> static const struct dev_pm_ops ish_pm_ops = {
> .suspend = ish_suspend,
> .resume = ish_resume,
> @@ -301,7 +301,7 @@ static const struct dev_pm_ops ish_pm_ops = {
> #define ISHTP_ISH_PM_OPS (&ish_pm_ops)
> #else
> #define ISHTP_ISH_PM_OPS NULL
> -#endif
> +#endif /* CONFIG_PM */
>
> static struct pci_driver ish_driver = {
> .name = KBUILD_MODNAME,
Powered by blists - more mailing lists