linux-kernel - Re: [PATCH 05/60] target: avoid to access .bi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161031152642.GC30919@infradead.org>
Date:   Mon, 31 Oct 2016 08:26:42 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Ming Lei <tom.leiming@...il.com>
Cc:     Jens Axboe <axboe@...com>, linux-kernel@...r.kernel.org,
        linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Christoph Hellwig <hch@...radead.org>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        "Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
        "open list:TARGET SUBSYSTEM" <linux-scsi@...r.kernel.org>,
        "open list:TARGET SUBSYSTEM" <target-devel@...r.kernel.org>
Subject: Re: [PATCH 05/60] target: avoid to access .bi_vcnt directly

On Sat, Oct 29, 2016 at 04:08:04PM +0800, Ming Lei wrote:
> When the bio is full, bio_add_pc_page() will return zero,
> so use this way to handle full bio.
> 
> Also replace access to .bi_vcnt for pr_debug() with bio_segments().
> 
> Signed-off-by: Ming Lei <tom.leiming@...il.com>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@....de>