linux-kernel - [GIT PULL] TPM bugfix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.20.1611010227190.11391@namei.org>
Date:   Tue, 1 Nov 2016 02:28:28 +1100 (AEDT)
From:   James Morris <jmorris@...ei.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
cc:     linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Subject: [GIT PULL] TPM bugfix

Please pull this fix for 4.9.

The following changes since commit 2a26d99b251b8625d27aed14e97fc10707a3a81f:

  Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2016-10-29 20:33:20 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git for-linus

for you to fetch changes up to befd99656c5eb765fe9d96045c4cba099fd938db:

  tpm: remove invalid min length check from tpm_do_selftest() (2016-10-31 09:15:27 -0600)

----------------------------------------------------------------
Jarkko Sakkinen (1):
      tpm: remove invalid min length check from tpm_do_selftest()

 drivers/char/tpm/tpm-interface.c | 3 ---
 1 file changed, 3 deletions(-)


---

commit befd99656c5eb765fe9d96045c4cba099fd938db
Author: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Date:   Tue Oct 4 09:49:47 2016 +0300

    tpm: remove invalid min length check from tpm_do_selftest()
    
    Removal of this check was not properly amended to the original commit.
    
    Cc: stable@...r.kernel.org
    Fixes: 0c541332231e ("tpm: use tpm_pcr_read_dev() in tpm_do_selftest()")
    Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
    Signed-off-by: James Morris <james.l.morris@...cle.com>

diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
index 8de6187..3a9149c 100644
--- a/drivers/char/tpm/tpm-interface.c
+++ b/drivers/char/tpm/tpm-interface.c
@@ -813,9 +813,6 @@ int tpm_do_selftest(struct tpm_chip *chip)
 			continue;
 		}
 
-		if (rc < TPM_HEADER_SIZE)
-			return -EFAULT;
-
 		if (rc == TPM_ERR_DISABLED || rc == TPM_ERR_DEACTIVATED) {
 			dev_info(&chip->dev,
 				 "TPM is disabled/deactivated (0x%X)\n", rc);