linux-kernel - Re: [PATCH 3/4] loop: Add 'lo_logical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161101140127.GB16815@lst.de>
Date:   Tue, 1 Nov 2016 15:01:27 +0100
From:   Christoph Hellwig <hch@....de>
To:     Hannes Reinecke <hare@...e.de>
Cc:     Jens Axboe <axboe@...com>, Christoph Hellwig <hch@....de>,
        Alexander Graf <agraf@...e.com>, Ming@...e.de,
        "Lei <tom.leiming"@gmail.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] loop: Add 'lo_logical_blocksize'

On Mon, Oct 31, 2016 at 08:37:18PM +0100, Hannes Reinecke wrote:
> Add a new field 'lo_logical_blocksize' to hold the logical
> blocksize of the loop device.

Why do we use the same flag for both block sizes?  If there is a good
reason for that it should be documented and both should be in the same
patch.