linux-kernel - Re: [PATCH 1/6] staging: iio: set proper supply name to devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Nov 2016 20:58:23 +0100
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Matt Ranostay <matt@...ostay.consulting>,
        Eva Rachel Retuya <eraretuya@...il.com>
Cc:     linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Michael.Hennerich@...log.com, Jonathan Cameron <jic23@...nel.org>,
        knaack.h@....de, pmeerw@...erw.net, gregkh@...uxfoundation.org
Subject: Re: [PATCH 1/6] staging: iio: set proper supply name to
 devm_regulator_get()

On 11/01/2016 05:03 AM, Matt Ranostay wrote:
> On Mon, Oct 31, 2016 at 10:04 AM, Eva Rachel Retuya <eraretuya@...il.com> wrote:
>> The name passed to devm_regulator_get() should match the name of the
>> supply as specified in the device datasheet. This makes it clear what
>> power supply is being referred to in case of presence of other
>> regulators.
>>
>> Currently, the supply name specified on the affected devices is 'vcc'.
>> Use lowercase version of the datasheet name to specify the supply
>> voltage.
>>
> 
> Aren't we possibly breaking current device tree definitions that
> people may have? We should still check the old name after the new
> datasheet name in my opinion.

None of those drivers have DT bindings, so I think we are OK. And they are
in staging anyway.