linux-kernel - Re: [PATCH 1/6] staging: iio: set proper supply name to devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161104101753.GA17800@Socrates-DK>
Date:   Fri, 4 Nov 2016 18:17:54 +0800
From:   Eva Rachel Retuya <eraretuya@...il.com>
To:     Matt Ranostay <matt@...ostay.consulting>
Cc:     linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael.Hennerich@...log.com, Jonathan Cameron <jic23@...nel.org>,
        knaack.h@....de, pmeerw@...erw.net, gregkh@...uxfoundation.org
Subject: Re: [PATCH 1/6] staging: iio: set proper supply name to
 devm_regulator_get()

Hello Matt,

On Mon, Oct 31, 2016 at 09:03:57PM -0700, Matt Ranostay wrote:
> On Mon, Oct 31, 2016 at 10:04 AM, Eva Rachel Retuya <eraretuya@...il.com> wrote:
> > The name passed to devm_regulator_get() should match the name of the
> > supply as specified in the device datasheet. This makes it clear what
> > power supply is being referred to in case of presence of other
> > regulators.
> >
> > Currently, the supply name specified on the affected devices is 'vcc'.
> > Use lowercase version of the datasheet name to specify the supply
> > voltage.
> >
> 
> Aren't we possibly breaking current device tree definitions that
> people may have? We should still check the old name after the new
> datasheet name in my opinion.
> 

I was told it was okay to rename those IIO drivers under staging. I also
double-checked if there are available DT bindings for these drivers and
found none.

Thanks,
Eva

> > Suggested-by: Lars-Peter Clausen <lars@...afoo.de>
> > Signed-off-by: Eva Rachel Retuya <eraretuya@...il.com>
> > ---
> >  drivers/staging/iio/adc/ad7192.c                | 2 +-
> >  drivers/staging/iio/adc/ad7780.c                | 2 +-
> >  drivers/staging/iio/frequency/ad9832.c          | 2 +-
> >  drivers/staging/iio/frequency/ad9834.c          | 2 +-
> >  drivers/staging/iio/impedance-analyzer/ad5933.c | 2 +-
> >  5 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> > index bfa12ce..41fb32d 100644
> > --- a/drivers/staging/iio/adc/ad7192.c
> > +++ b/drivers/staging/iio/adc/ad7192.c
> > @@ -633,7 +633,7 @@ static int ad7192_probe(struct spi_device *spi)
> >
> >         st = iio_priv(indio_dev);
> >
> > -       st->reg = devm_regulator_get(&spi->dev, "vcc");
> > +       st->reg = devm_regulator_get(&spi->dev, "avdd");
> >         if (!IS_ERR(st->reg)) {
> >                 ret = regulator_enable(st->reg);
> >                 if (ret)
> > diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
> > index c9a0c2a..a88236e 100644
> > --- a/drivers/staging/iio/adc/ad7780.c
> > +++ b/drivers/staging/iio/adc/ad7780.c
> > @@ -173,7 +173,7 @@ static int ad7780_probe(struct spi_device *spi)
> >
> >         ad_sd_init(&st->sd, indio_dev, spi, &ad7780_sigma_delta_info);
> >
> > -       st->reg = devm_regulator_get(&spi->dev, "vcc");
> > +       st->reg = devm_regulator_get(&spi->dev, "avdd");
> >         if (!IS_ERR(st->reg)) {
> >                 ret = regulator_enable(st->reg);
> >                 if (ret)
> > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> > index 358400b..744c8ee 100644
> > --- a/drivers/staging/iio/frequency/ad9832.c
> > +++ b/drivers/staging/iio/frequency/ad9832.c
> > @@ -212,7 +212,7 @@ static int ad9832_probe(struct spi_device *spi)
> >                 return -ENODEV;
> >         }
> >
> > -       reg = devm_regulator_get(&spi->dev, "vcc");
> > +       reg = devm_regulator_get(&spi->dev, "avdd");
> >         if (!IS_ERR(reg)) {
> >                 ret = regulator_enable(reg);
> >                 if (ret)
> > diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c
> > index 6366216..ca3cea6 100644
> > --- a/drivers/staging/iio/frequency/ad9834.c
> > +++ b/drivers/staging/iio/frequency/ad9834.c
> > @@ -329,7 +329,7 @@ static int ad9834_probe(struct spi_device *spi)
> >                 return -ENODEV;
> >         }
> >
> > -       reg = devm_regulator_get(&spi->dev, "vcc");
> > +       reg = devm_regulator_get(&spi->dev, "avdd");
> >         if (!IS_ERR(reg)) {
> >                 ret = regulator_enable(reg);
> >                 if (ret)
> > diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> > index 5eecf1c..62f61bc 100644
> > --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> > +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> > @@ -723,7 +723,7 @@ static int ad5933_probe(struct i2c_client *client,
> >         if (!pdata)
> >                 pdata = &ad5933_default_pdata;
> >
> > -       st->reg = devm_regulator_get(&client->dev, "vcc");
> > +       st->reg = devm_regulator_get(&client->dev, "vdd");
> >         if (!IS_ERR(st->reg)) {
> >                 ret = regulator_enable(st->reg);
> >                 if (ret)
> > --
> > 2.7.4
> >