linux-kernel - Re: [PATCHv2 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161102080138.GQ13127@dell>
Date:   Wed, 2 Nov 2016 08:01:39 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Thor Thayer <tthayer@...nsource.altera.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com,
        dinguyen@...nsource.altera.com, linux@...linux.org.uk,
        arnd@...db.de, gregkh@...uxfoundation.org, davem@...emloft.net,
        geert@...ux-m68k.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCHv2 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor

On Mon, 31 Oct 2016, Thor Thayer wrote:
> On 10/31/2016 03:02 AM, Lee Jones wrote:
> > On Thu, 27 Oct 2016, tthayer@...nsource.altera.com wrote:
> > 
> > > From: Thor Thayer <tthayer@...nsource.altera.com>
> > > 
> > > Add the Altera Arria10 DevKit System Resource Monitor functionality
> > > to the MFD device.
> > > 
> > > Signed-off-by: Thor Thayer <tthayer@...nsource.altera.com>
> > > ---
> > > v2  Change from -mon to -monitor for clarity
> > > ---
> > >  drivers/mfd/altera-a10sr.c | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c
> > > index 06e1f7f..30de652 100644
> > > --- a/drivers/mfd/altera-a10sr.c
> > > +++ b/drivers/mfd/altera-a10sr.c
> > > @@ -33,6 +33,10 @@
> > >  		.name = "altr_a10sr_gpio",
> > >  		.of_compatible = "altr,a10sr-gpio",
> > >  	},
> > > +	{
> > > +		.name = "altr_a10sr_monitor",
> > > +		.of_compatible = "altr,a10sr-monitor",
> > 
> > So long as you use whichever compatible you agree on with Rob:
> > 
> > For my own reference:
> >   Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>
> > 
> I'm getting a "Non-standard signature" warning for this (even if I make
> everything lower-case).
> 
> Would you prefer I submit it with the warning or should I change it to
> "Acked-by"?

Please submit it as you see it.  I will amend when applying.

> Thanks for reviewing!
> 
> Thor
> 
> > > +	},
> > >  };
> > > 
> > >  static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg)
> > 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog