linux-kernel - Re: [PATCH] CHROMIUM: ec: register shutdown function to clear delayed works

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Nov 2016 15:59:40 +0800
From:   Daniel Hung-yu Wu <hywu@...gle.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Samuel Ortiz <sameo@...ux.intel.com>, hywu@...omium.org,
        ejcaruso@...omium.org, drinkcat@...omium.org, kyan@...omium.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] CHROMIUM: ec: register shutdown function to clear
 delayed works

On Wed, Oct 26, 2016 at 03:22:14PM +0100, Lee Jones wrote:
> On Wed, 26 Oct 2016, Lee Jones wrote:
> 
> > On Mon, 24 Oct 2016, Daniel Hung-yu Wu wrote:
> > 
> > > This patch applies on top of "mfd: cros_ec: Add EC console read structures
> > > definitions" (https://patchwork.kernel.org/patch/9294887/).
> > > 
> > > This patch is currently against a linux 3.18 kernel.
> > > 
> > > Reboot or shutdown during delayed works could corrupt communication with EC,
> > > and certain I2C controller may not be able to recover from the error state.
> > > A shutdown function is registered to clear delayed works or wait for them to
> > > finish.
> > > 
> > > Signed-off-by: Daniel Hung-yu Wu <hywu@...omium.org>
> > > ---
> > >  drivers/mfd/cros_ec_dev.c | 9 +++++++++
> > >  1 file changed, 9 insertions(+)
> > 
> > Applied, thanks.
> 
> Ah, I thought you'd at least ported it to Mainline!
> 
> You need to do that before posting patches.
> 
> > > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> > > index 8618a7c..3e548f1 100644
> > > --- a/drivers/mfd/cros_ec_dev.c
> > > +++ b/drivers/mfd/cros_ec_dev.c
> > > @@ -613,6 +613,14 @@ static int ec_device_remove(struct platform_device *pdev)
> > >  	return 0;
> > >  }
> > >  
> > > +static void ec_device_shutdown(struct platform_device *pdev)
> > > +{
> > > +	struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev);
> > > +
> > > +	/* Be sure to clear up debugfs delayed works */
> > > +	cros_ec_debugfs_remove(ec);
> > > +}
> > > +
> > >  static int ec_device_suspend(struct device *dev)
> > >  {
> > >  	struct cros_ec_dev *ec = dev_get_drvdata(dev);
> > > @@ -656,6 +664,7 @@ static struct platform_driver cros_ec_dev_driver = {
> > >  	},
> > >  	.probe = ec_device_probe,
> > >  	.remove = ec_device_remove,
> > > +	.shutdown = ec_device_shutdown,
> > >  };
> > >  
> > >  static int __init cros_ec_dev_init(void)
> > 
> 
> -- 
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

The patch for Mainline is submitted. Thanks.