linux-kernel - Re: [PATCH] PCI: designware: check for iATU unroll support after initializing host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOesGMiCYh+fHKpcv6w19WtcZa2g+jj+Zn5OF5-2CaeR1=86HA@mail.gmail.com>
Date:   Wed, 2 Nov 2016 08:48:02 -0700
From:   Olof Johansson <olof@...om.net>
To:     Niklas Cassel <niklas.cassel@...s.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Cc:     Jingoo Han <jingoohan1@...il.com>, pratyush.anand@...il.com,
        Joao.Pinto@...opsys.com,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Niklas Cassel <niklass@...s.com>
Subject: Re: [PATCH] PCI: designware: check for iATU unroll support after
 initializing host

Hi,

On Fri, Oct 14, 2016 at 2:54 PM, Niklas Cassel <niklas.cassel@...s.com> wrote:
> From: Niklas Cassel <niklas.cassel@...s.com>
>
> dw_pcie_iatu_unroll_enabled reads a dbi_base register.
> Reading any dbi_base register before pp->ops->host_init has been called
> causes "imprecise external abort" on platforms like ARTPEC-6, where the
> PCIe module is disabled at boot and first enabled in pp->ops->host_init.
> Move dw_pcie_iatu_unroll_enabled to dw_pcie_setup_rc, since it is after
> pp->ops->host_init, but before pp->iatu_unroll_enabled is actually used.
>
> Fixes: a0601a470537 ("PCI: designware: Add iATU Unroll feature")
> Signed-off-by: Niklas Cassel <niklas.cassel@...s.com>

This fixes the regression I've seen on i.MX6 devices in my board farm as well.

Acked-by: Olof Johansson <olof@...om.net>

Bjorn, can you please pick this up and get it sent up for 4.9-rc soon?
I worry about losing bisectability if this remains broken for a while.
Thanks!


-Olof