linux-kernel - Re: [PATCH] clk: rockchip: fix some clocks' name to be more standard style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44798035.VNVnDcOLnj@diego>
Date:   Thu, 03 Nov 2016 15:32:13 +0100
From:   Heiko Stübner <heiko@...ech.de>
To:     Shawn Lin <shawn.lin@...k-chips.com>
Cc:     Jianqun Xu <jay.xu@...k-chips.com>, mturquette@...libre.com,
        sboyd@...eaurora.org, huangtao@...k-chips.com,
        zhangqing@...k-chips.com, zhengxing@...k-chips.com,
        linux-kernel@...r.kernel.org, lintao@...k-chips.com,
        linux-rockchip@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] clk: rockchip: fix some clocks' name to be more standard style

Am Donnerstag, 3. November 2016, 16:52:48 schrieb Shawn Lin:
> On 2016/11/2 15:04, Jianqun Xu wrote:
> > Fix aclk_emmcgrf to aclk_emmc_grf, and fix aclk_emmccore to be
> > aclk_emmc_core.
> 
> What is the standard style should be?
> 
> TRM uses aclk_emmccore but not aclk_emmc_core, so should it be more
> standrad to keep it as-is?

I tend to agree with Shawn. While it looks like the missing "_" is some sort 
of mistake, we should strive to follow TRM naming, so grepping so it becomes 
easier to look for informations in these things in the TRM.

Same reason for naming our regulators and pinctrl after the names used in 
device schematics, if available.


Heiko