linux-kernel - Re: [PATCH V2 2/2] blk-mq: immediately dispatch big size request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d7144e3-47e5-3c98-489f-e92d97b60817@fb.com>
Date:   Fri, 4 Nov 2016 09:29:07 -0600
From:   Jens Axboe <axboe@...com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     Shaohua Li <shli@...com>, <linux-block@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <Kernel-team@...com>
Subject: Re: [PATCH V2 2/2] blk-mq: immediately dispatch big size request

On 11/04/2016 08:46 AM, Christoph Hellwig wrote:
> On Thu, Nov 03, 2016 at 10:00:58PM -0600, Jens Axboe wrote:
>> I've applied 1-2 for 4.10, but we probably should look into unifying
>> those parts of sq and mq in general. For instance, it doesn't seem to
>> make a lot of sense why we'd depth limit sq and not mq.
>
> I've spent some time looking the the make_request_fn and to be honest
> I think that whole sq vs mq split is pointless.  They are about 70-80%
> the same anyway, and I think everyone would be served much better
> by merging them.

Yeah, that was my point, at least if we can do it without having too
many extra conditionals. Or at least split some of it into helpers.

-- 
Jens Axboe