linux-kernel - Re: [PATCH 3/5] block: move poll code to blk-mq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a3933168-a17c-1e98-4a95-3e79f0d4beb0@fb.com>
Date:   Fri, 4 Nov 2016 09:30:00 -0600
From:   Jens Axboe <axboe@...com>
To:     Christoph Hellwig <hch@....de>
CC:     <axboe@...nel.dk>, <linux-kernel@...r.kernel.org>,
        <linux-block@...r.kernel.org>
Subject: Re: [PATCH 3/5] block: move poll code to blk-mq

On 11/04/2016 08:44 AM, Christoph Hellwig wrote:
> On Thu, Nov 03, 2016 at 01:45:05PM -0600, Jens Axboe wrote:
>> The poll code is blk-mq specific, let's move it to blk-mq.c. This
>> is a prep patch for improving the polling code.
>>
>> Signed-off-by: Jens Axboe <axboe@...com>
>> Reviewed-by: Christoph Hellwig <hch@....de>
>
> So I gave my ok earlier, but I spent some more time looking at this
> this morning and now I wonder why we even bother to keep some
> code in blk-core.c.  How about just renaming the whole damn thing
> to blk_mq_poll and move it to blk-mq.c instead of that split?

I pondered that too, and I guess we might as well since the likelihood
of supporting polling on non-mq is pretty close to 0%.

-- 
Jens Axboe