linux-kernel - [PATCH] pstore/dump: solution pstore data abort.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 5 Nov 2016 10:15:59 +0800
From:   Li Pengcheng <lipengcheng8@...wei.com>
To:     <anton@...msg.org>, <ccross@...roid.com>, <keescook@...omium.org>,
        <tony.luck@...el.com>, <linux-kernel@...r.kernel.org>,
        <liuhailong5@...wei.com>
CC:     <lipengcheng8@...wei.com>, <lizhong11@...ilicon.com>,
        <liuyongfu@...ilicon.com>, <dan.zhao@...ilicon.com>,
        <suzhuangluan@...ilicon.com>
Subject: [PATCH] pstore/dump: solution pstore data abort.

If not return,data abort will happen
when two threads call pstore_dump at the same time.

Signed-off-by: Liu Hailong <liuhailong5@...wei.com>
Signed-off-by: Li Pengcheng <lipengcheng8@...wei.com>
Signed-off-by: Li Zhong <lizhong11@...ilicon.com>
---
 fs/pstore/platform.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index 14984d9..60e6db6 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -493,6 +493,7 @@ static void pstore_dump(struct kmsg_dumper *dumper,
 		if (!is_locked) {
 			pr_err("pstore dump routine blocked in %s path, may corrupt error record\n"
 				       , in_nmi() ? "NMI" : why);
+			return;
 		}
 	} else {
 		spin_lock_irqsave(&psinfo->buf_lock, flags);
-- 
1.9.1