linux-kernel - Re: [PATCH] pstore/dump: solution pstore data abort.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Nov 2016 16:44:27 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Li Pengcheng <lipengcheng8@...wei.com>
Cc:     Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        LKML <linux-kernel@...r.kernel.org>, liuhailong5@...wei.com,
        lizhong11@...ilicon.com, liuyongfu@...ilicon.com,
        dan.zhao@...ilicon.com, suzhuangluan@...ilicon.com
Subject: Re: [PATCH] pstore/dump: solution pstore data abort.

On Fri, Nov 4, 2016 at 7:15 PM, Li Pengcheng <lipengcheng8@...wei.com> wrote:
> If not return,data abort will happen
> when two threads call pstore_dump at the same time.
>
> Signed-off-by: Liu Hailong <liuhailong5@...wei.com>
> Signed-off-by: Li Pengcheng <lipengcheng8@...wei.com>
> Signed-off-by: Li Zhong <lizhong11@...ilicon.com>
> ---
>  fs/pstore/platform.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
> index 14984d9..60e6db6 100644
> --- a/fs/pstore/platform.c
> +++ b/fs/pstore/platform.c
> @@ -493,6 +493,7 @@ static void pstore_dump(struct kmsg_dumper *dumper,
>                 if (!is_locked) {
>                         pr_err("pstore dump routine blocked in %s path, may corrupt error record\n"
>                                        , in_nmi() ? "NMI" : why);
> +                       return;
>                 }
>         } else {
>                 spin_lock_irqsave(&psinfo->buf_lock, flags);
> --
> 1.9.1

Ah, thanks! I've queued this for -next.

-Kees

-- 
Kees Cook
Nexus Security