linux-kernel - Re: [PATCH] acer-wmi: only supports AMW0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161105182720.GC100528@f23x64.localdomain>
Date:   Sat, 5 Nov 2016 11:27:20 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Anthony Wong <ypwong@...il.com>
Cc:     "Lee, Chun-Yi" <joeyli.kernel@...il.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Lee, Chun-Yi" <jlee@...e.com>
Subject: Re: [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family

On Thu, Nov 03, 2016 at 11:40:15AM +0800, Anthony Wong wrote:
> On 1 November 2016 at 12:30, Lee, Chun-Yi <joeyli.kernel@...il.com> wrote:
> >
> > The AMW0_GUID1 wmi is not only found on Acer family but also other
> > machines like Lenovo, Fujitsu and Medion. In the past days, acer-wmi
> > driver handled those non-Acer machines by quirks list.
> >
> > But actually acer-wmi driver was loaded on any machines that have
> > AMW0_GUID1. This behavior is strange because those machines should
> > be supported by appropriate wmi drivers. e.g. fujitsu-laptop,
> > ideapad-laptop.
> >
> > So, This patch adds the logic to check the machine that has AMW0_GUID1
> > should be in Acer/Packard Bell/Gateway white list. But, it still keeps
> > the quirk list of those supported non-acer machines for backward
> > compatible.
> >
> > Tested-by: Bjørn Mork <bjorn@...k.no>
> > Cc: Darren Hart <dvhart@...radead.org>
> > Signed-off-by: Lee, Chun-Yi <jlee@...e.com>
> 
> Xiaomi Air 13.3 notebook suffers from the same issue, acer-wmi
> basically has no use on this machine. With your patch, acer-wmi no
> longer loads.
> 
> Tested-by: Anthony Wong <anthony@...ong.org>

I've already pushed this to -next, but thank you for the confirmation.

-- 
Darren Hart
Intel Open Source Technology Center